Private Tasklist Tasks show in Client Dashboard!

This topic is locked, no new messages can be posted
avatar nokati Nov 27. 2006. 8:38 pm #1
Im using AC/0.7 and I decided to test out the private objects myself before giving a client access (because Im paranoid and would prefer they dont see my "Billing & Invoicing" tasklist, which was created private).

So i use a different browser and log in with the client account ive created: while I cannot see the private tasklist in "Tasks" I DO see the items that have been added to the private tasklist in the clients dashboard: which really defeats the purpose of having them private.

I assume this is a bug, and if correct one everyone should be aware of: could be rather embarassing.

Thanks and keep up the great work!
avatar Nov 27. 2006. 8:41 pm #2
Quick follow up: when I click on the task item in the client dashboard i get a nice big red box:
"You don't have permissions to access requested page".

Funny though - the client doesnt need to view the requested page, he already saw the contents via dashboard.

Essentially this means privacy is broken for tasks.
avatar Ilija Studen Staff Nov 28. 2006. 5:08 am #3
Thanks for the report. That is (was) a bug - Ticket #219. I've already patched it (see diff) and the change will be available in 0.7.1 (maintenance version for 0.7).

If you wish to patch it manually you can simply add this function:

/**
* Returns value of is private flag inehrited from parent task list
*
* @param void
* @return boolean
*/
function isPrivate() {
  $parent_list = $this->getTaskList();
  return $parent_list instanceof ProjectTaskList ? $parent_list->isPrivate() : true;
} // isPrivate


To ProjectTask class (located in /application/models/project_tasks/).

Btw, to make it work with existing tasks that are listed in clients activity logs you need to update that tasks (by editing them with some change and reverting to previous state). That is required to refresh the activity log because it caches the value of is private flag.
Follow @activecollab and activeCollab on Facebook.
avatar Nov 29. 2006. 12:26 am #4
Cool thanks much Ilija.

BTW - can you predict some rough ETA for timetracking? Im dyin waiting ;)

Topic is locked

If you have something important to say about the issues discussed in this post please write at hi@a51dev.com.