Task Commenting Hack - files updated

1, 2, 3
avatar Mar 7. 2007. 6:24 pm #11
Well I've double checked my error.log file, also tail'd it while I went through comment submission.
I don't get any errors thrown, only file that is updated is the access.log file (normal). I haven't looked in the code yet, as I don't have the time (at work). Error logging is on

All files are uploaded correctly..
avatar Mar 7. 2007. 11:20 pm #12
No one else has mentioned this issue, it's difficult to determine what the problem is if there is no error being generated...

Anyone else having this problem?
avatar Ilija Studen Staff Mar 8. 2007. 9:11 am #13
Jakub, have you read this page? It explains how you can learn more about problems activeCollab is experiencing. This people need to know more details in order to help so you should try running activeCollab in DEBUG mode and look into your log.php file (everything explained in linked document).
Follow @activecollab and activeCollab on Facebook.
avatar Ryan Cross Mar 8. 2007. 9:29 am #14
Hey Ilija,

i know i've seen a comment or two in the forums, but the page you linked to isn't linked from the website anymore. I am pretty sure both the developement and code/documentation links on the website were removed without any notice, so that might be why he hasn't seen that page. Hope that helps.

-Ryan
avatar Mar 16. 2007. 12:31 pm #15
I'm having a problem with permissions when using the "Task Commenting Hack":

I have 3 users assigned to one project. User1 assigns a task to User2, User2 adds a comment to this task. The problem is, that User3, who wants to have a look what is going on in this task, doesn't have the permission to access "task details". This is a problem because User3, who is also familiar with this project could add some valuable input, even if the task is not assigned to him.

How and what could I change in the configuration so that every user assigned to a specific project can access and comment all tasks in this project?


Thanks for any input!
Rainhard


PS:
I realize that User3 can access "task details" if the task is assigned to the "firm", but we want to keep tasks assigned to one specific user, who is then responsible for resolving the task.
avatar May 7. 2007. 6:29 pm #16
To validate Jakub's claim, I too experienced a blank page when I submitted a comment for a task. I enabled debugging and got this error:

Fatal error: Call to undefined method ProjectTask::getViewUrl() in C:\xampplite\htdocs\activecollab\application\controllers\CommentController.class.php on line 94

I checked ProjectTask.class.php and sure enough, it did not have getViewUrl() implemented, so I created my own:

function getViewUrl() {
  return $this->getDetailsUrl();
} // getViewUrl


and it fixed the error. While I was at it, I noticed the task list will say "1 Comments," if there is only 1.. If you're a perfectionist too, you can fix that on line 57 of views/task/task_list.php with:

echo $task->countComments() . ($task->countComments() == 1 ? " comment" : " comments")



Sidenote: Ilija, I've been a programmer for many years, and from what I've seen so far, your design is outstanding
avatar Ilija Studen Staff May 7. 2007. 7:50 pm #17
Thanks! Trick is to find the line between good design and overdesigned code and I'm still learning ;)

A minor problem with this piece of code:

echo $task->countComments() . ($task->countComments() == 1 ? " comment" : " comments")

Is that it is not multi-lang friendly. If you are using English translation that it's not a problem :)
Follow @activecollab and activeCollab on Facebook.
avatar May 9. 2007. 5:02 pm #18
I agree, it's quite hard to find a good balance. In this case it's not so bad to be a little over-designed, since it makes it a little easier for myself and others to modify your code to suit our needs.

Good point with the language. I forgot that I only have to worry about English. If anyone needs other languages, or you just want to do it right, you should use this instead:

echo $task->countComments() . " " . ($task->countComments() == 1 ? lang('comment') : lang('comments'))

(comment(s) should already be in the language files)
avatar kthomas Oct 16. 2007. 6:15 am #19
What is the status of this under 1.0?
avatar Ilija Studen Staff Oct 16. 2007. 8:07 am #20
Tickets (you can look at them as advanced tasks) support comments, subtasks, attachments, email notifications etc.
Follow @activecollab and activeCollab on Facebook.
or Go To Next Page