Login or Register

RSS IconRecent posts in this topic

avatar
Valdemar on Jan 26. 2008. 5:32 am
I will post a new version asap. Thanks to shrike I found a few issues. I'm gonna leave out any font requirements as they seem to cause issues (the illegal image size). Also, make sure that the /cache dir is accesible, meaning not blocked by a htaccess - this path should be changed to somewhere inside /public or a subdir to /cache in the future.
Casper Valdemar
avatar
Ilija Studen on Jan 26. 2008. 6:32 am
A small offtopic:

/cache should never be publicly accessible because activeCollab cache may contain some sensitive data. In activeCollab 1.1 we'll include two more directories:

/work - for system level work folder
/public/work - as publicly accessible work folder

Please note that publicly accessible data should have some sort of protection (still, you are displaying sensitive data on charts). You can check /public/thumbs.php to see how thumbnail utility is implemented - in order to access a file you need to know it's exact file size - information that is hard to obtain if you don't have direct access to the files (hard to guess), but simple to obtain from the script.

Just something to think about :)

Thanks for all your hard work!
activeCollab team member
avatar
adria.richards on Jan 26. 2008. 10:54 pm
My tweaks were:

MySQL statement
-------------------------------
Changed from:
INSERT INTO modules values ( 'charts' , 0 , 100 );

To:
INSERT INTO acx_modules values ( 'charts' , 0 , 100 );

Examples
---------------------------
Searched for:
Milestone

Replace all with:
JPMilestone

Note: The Ganttex01.php needed the two "src" items changed to ".."

Fonts
--------------------
I created a directory inside "jpgraph" called "fonts"

Googling, I found the needed JPGraph fonts are:
arial.ttf
arialbd.ttf
ariali.ttf
bookant.ttf
bookantbd.ttf
bookantbi.ttf
bookanti.ttf
comic.ttf
comicbd.ttf
courier.ttf
courierbd.ttf
courierbi.ttf
courieri.ttf
handwriting.ttf
tahoma.ttf
tahomabd.ttf
times.ttf
timesbd.ttf
timesbi.ttf
timesi.ttf
verdana.ttf
verdanab.ttf
verdanabd.ttf
verdanai.ttf

I made sure the absolute directory path was correct so in my case, I changed the following in the "jp-config.inc.php" file located in activecollab/application/modules/charts/helpers/jpgraph/ from:
DEFINE("TTF_DIR","/usr/share/fonts/truetype/msttcorefonts/");

to:
DEFINE("TTF_DIR","/mywebdirectory/into/activecollab/application/modules/charts/helpers/jpgraph/fonts/");

I tried a relative path and the examples were loading but not the client side graphs.




avatar
adria.richards on Jan 26. 2008. 11:13 pm
Vlademar,

Great job even if I can't generate a chart yet!
avatar
adria.richards on Jan 27. 2008. 1:26 am
The image path for the gantt chart doesn't seem correct

<h2 class="section_name"><span class="section_name_span">Generated chart</span></h2>
<div id="section_container">
<img src="/cache/26927b2572e268d373692af533b881f2.png" alt="JPGraph Generated Chart" />
</div>

I will test with an absolute path to the cache
avatar
Oliver Maksimović on Jan 27. 2008. 8:43 am
adria:

MySQL statement
-------------------------------
Changed from:
INSERT INTO modules values ( 'charts' , 0 , 100 );

To:
INSERT INTO acx_modules values ( 'charts' , 0 , 100 );


Beware of table prefix, as it may not always be "acx_" (if you're releasing it to the public).
activeCollab team member, too ;)
avatar
adria.richards on Jan 27. 2008. 12:11 pm
After a night of tweaking, here is my gantt chart layout.

The only thing I don't like is the JPGraph fonts don't look crisp.
avatar
adria.richards on Jan 28. 2008. 1:42 am
I got my chart showing up in the charts tab so no more rooting around in the cache folder.

:)
avatar
shrike on Feb 3. 2008. 3:08 am
One minor detail: if you have a very long project, there should be ability open chart in bigger window to display all milestones as many months ahead as needed. Or then there should be scroll under the chartview.
avatar
gcortesi on Feb 3. 2008. 11:35 am
Casper - do you have a new update to the module that incorporates all the changes. I am still unable to get the module to function as I posted earlier.

Thanks for the help.

Guy

RSS IconRecent posts in this topic