We're currently translating aC to Danish and have in the process discovered an issue with the "Welcome back :display!" flash success when you login. It appears that this message is generated before the user's preferred language is loaded, so the welcome message defaults to the language the system is using.
It's easy to check, just have a different language selected on the user you want to login with, and have the system default language as another. You'll see that the welcome flash message appears in the system default language while the rest of the page is translated properly. Now try switching the system default language and notice that the welcome message changes.
I don't think this is the intended behavior as it kind of ruins the point of having translations if they aren't loaded completely.
activecollab/application/modules/system/lang_index.php: 356 => ':role is a project role. It is used to define witch sections of a single project users can access and use.',
activecollab/application/modules/system/views/roles_admin/view.tpl: <p>{lang role=$active_role->getName()}:role is a project role. It is used to define witch sections of a single project users can access and use.{/lang}</p>
- Error here is the word "witch". Witches also appear in comments in the code.
activecollab/application/modules/system/lang_index.php: 780 => 'Option name muust be unique',
activecollab/application/modules/system/models/config_options/ConfigOption.class.php: $errors->addError(lang('Option name muust be unique'), 'name');
activecollab/application/modules/system/lang_index.php: 572 => 'File ":file" has not beed added',
activecollab/application/modules/system/controllers/ProjectObjectsController.class.php: flash_error('File ":file" has not beed added', array('file' => $file['name']));
- Error here is the word "beed".
activecollab/application/modules/system/lang_index.php: 494 => 'Failed t archive ":name"',
activecollab/application/modules/system/controllers/CompaniesController.class.php: $error_message = lang('Failed t archive ":name"', array('name' => $this->active_company->getName()));
- Error here is "t" should be "to".
activecollab/application/modules/system/lang_index.php: 496 => 'Failed t move ":name" from the archive to the list of active companies',
activecollab/application/modules/system/controllers/CompaniesController.class.php: $error_message = lang('Failed t move ":name" from the archive to the list of active companies', array('name' => $this->active_company->getName()));
- Same as above.
activecollab/application/modules/system/lang_index.php: 176 => 'JavaScript is a System Requrement',
activecollab/application/modules/system/views/empty_slates/js_disabled.tpl: <span class="icon_list_title">{lang}JavaScript is a System Requrement{/lang}</span>
- There's missing an 'i' in Requirement.
activecollab/application/modules/system/lang_index.php: 181 => 'Click on <strong>Security</strong> tab and than on <strong>Custom Level...</strong> button',
activecollab/application/modules/system/views/empty_slates/js_disabled.tpl: <li>{lang}Click on <strong>Security</strong> tab and than on <strong>Custom Level...</strong> button{/lang}</li>
- Here "than" should be "then".
activecollab/application/modules/system/lang_index.php: 187 => 'Make sure that <strong>Enable JavaScript</strong> option in checked',
activecollab/application/modules/system/lang_index.php: 192 => 'Make sure that <strong>Enable JavaScript</strong> option in checked in Web content section',
activecollab/application/modules/system/views/empty_slates/js_disabled.tpl: <li>{lang}Make sure that <strong>Enable JavaScript</strong> option in checked{/lang}</li>
activecollab/application/modules/system/views/empty_slates/js_disabled.tpl: <li>{lang}Make sure that <strong>Enable JavaScript</strong> option in checked in Web content section{/lang}</li>
- In both these "option in checked" should be "option is checked".
activecollab/application/modules/documents/lang_index.php: 18 => 'This document is visibile only to members of :company_name company',
activecollab/application/modules/documents/controllers/DocumentsController.class.php: $this->wireframe->addPageMessage(lang('This document is visibile only to members of :company_name company', array('company_name' => $this->owner_company->getName())), 'private');
activecollab/application/modules/documents/views/documents/index.tpl: <img src="{image_url name=private.gif}" title="{lang company_name=$owner_company->getName()}This document is visibile only to members of :company_name company{/lang}" />
activecollab/application/modules/system/lang_index.php: 319 => 'This object is visibile to anyone involved with ":project" project',
activecollab/application/modules/system/views/project_objects/visibility.tpl: <p>{lang project=$active_project->getName()}This object is visibile to anyone involved with ":project" project{/lang}.</p>
- In this mass the word "visibile" should be "visible".
activecollab/angie/classes/mailboxmanager/MailboxManager.class.php: new Error(lang('You are not connected, cannot execut command'), true);
activecollab/application/modules/system/lang_index_common.php: 10 => 'You are not connected, cannot execut command',
- There's missing and 'e' in "execute".
activecollab/application/modules/resources/lang_index.php: 107 => 'There are no tagged object in this project',
activecollab/application/modules/resources/views/tags/index.tpl:<p>{lang}There are no tagged object in this project{/lang}</p>
- I assume "object" should be "objects".
That was all I could find currently. I'll inform you if I find more.
We noticed the group settings tags weren't translated (Mail, Tools & Other defined in activecollab/application/modules/system/init.php), so we had to add the entries for these in the system language file as well:
It's easy to check, just have a different language selected on the user you want to login with, and have the system default language as another. You'll see that the welcome flash message appears in the system default language while the rest of the page is translated properly. Now try switching the system default language and notice that the welcome message changes.
I don't think this is the intended behavior as it kind of ruins the point of having translations if they aren't loaded completely.
Frederik Sauer
Dwarf A/S